Handling error for the API request and add commments

[ci skip]
tokarchuk/v1.17
Antoine GIRARD 9 years ago
parent 303d091ea9
commit 81e5722bcc
  1. 18
      routers/api/v1/repo/branch.go

@ -14,36 +14,42 @@ import (
// Temporary: https://gist.github.com/sapk/df64347ff218baf4a277#get-a-branch // Temporary: https://gist.github.com/sapk/df64347ff218baf4a277#get-a-branch
// https://github.com/gogits/go-gogs-client/wiki/Repositories-Branches#get-a-branch // https://github.com/gogits/go-gogs-client/wiki/Repositories-Branches#get-a-branch
func GetBranch(ctx *middleware.Context) { func GetBranch(ctx *middleware.Context) {
//Getting the branch requested
branch, err := ctx.Repo.Repository.GetBranch(ctx.Params(":id")) branch, err := ctx.Repo.Repository.GetBranch(ctx.Params(":id"))
if err != nil { if err != nil {
//TODO handle error ctx.APIError(500, "Repository.GetBranch", err)
return return
} }
//Getting the last commit of the branch
c, err := branch.GetCommit() c, err := branch.GetCommit()
if err != nil { if err != nil {
//TODO handle error ctx.APIError(500, "Branch.GetCommit", err)
return return
} }
//Converting to API format and send payload
ctx.JSON(200, convert.ToApiBranch(branch,c)) ctx.JSON(200, convert.ToApiBranch(branch,c))
} }
// Temporary: https://gist.github.com/sapk/df64347ff218baf4a277#list-branches // Temporary: https://gist.github.com/sapk/df64347ff218baf4a277#list-branches
// https://github.com/gogits/go-gogs-client/wiki/Repositories-Branches#list-branches // https://github.com/gogits/go-gogs-client/wiki/Repositories-Branches#list-branches
func ListBranches(ctx *middleware.Context) { func ListBranches(ctx *middleware.Context) {
//Listing of branches
Branches, err := ctx.Repo.Repository.GetBranches() Branches, err := ctx.Repo.Repository.GetBranches()
if err != nil { if err != nil {
//TODO handle error ctx.APIError(500, "Repository.GetBranches", err)
return return
} }
//Getting the last commit of each branch
apiBranches := make([]*api.Branch, len(Branches)) apiBranches := make([]*api.Branch, len(Branches))
for i := range Branches { for i := range Branches {
c, err := Branches[i].GetCommit() c, err := Branches[i].GetCommit()
if err != nil { if err != nil {
//TODO handle error ctx.APIError(500, "Branch.GetCommit", err)
continue return
} }
//Converting to API format
apiBranches[i] = convert.ToApiBranch(Branches[i],c) apiBranches[i] = convert.ToApiBranch(Branches[i],c)
} }
//Sending the payload
ctx.JSON(200, &apiBranches) ctx.JSON(200, &apiBranches)
} }

Loading…
Cancel
Save