Check permission for the appropriate unit type (#14261)

* Check permission for the appropriate unit type

Fixes false positives for "User created Issues in Repository which they no longer have access to" errors

* change log level to Debug

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
tokarchuk/v1.17
Jimmy Praet 4 years ago committed by GitHub
parent d1581a4563
commit 8224f03a23
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      routers/user/home.go

@ -551,8 +551,8 @@ func Issues(ctx *context.Context) {
ctx.ServerError("GetUserRepoPermission", fmt.Errorf("[%d]%v", repoID, err)) ctx.ServerError("GetUserRepoPermission", fmt.Errorf("[%d]%v", repoID, err))
return return
} }
if !perm.CanRead(models.UnitTypeIssues) { if !perm.CanRead(unitType) {
log.Error("User created Issues in Repository which they no longer have access to: [%d]", repoID) log.Debug("User created Issues in Repository which they no longer have access to: [%d]", repoID)
} }
} }
} }

Loading…
Cancel
Save