third_party
/
gitea
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent "Race" detected in TestAdmin*User (#16830)

Browse Source 
These tests are missing the defer prefix.

Related #1441

Signed-off-by: Andrew Thornton <art27@cantab.net>
tokarchuk/v1.17
zeripath 3 years ago committed by GitHub
parent e37342db0c
commit cd8db3a83d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 6
      integrations/admin_user_test.go

6
integrations/admin_user_test.go
Unescape View File

@ -15,7 +15,7 @@ import (
) )
func TestAdminViewUsers(t *testing.T) { func TestAdminViewUsers(t *testing.T) {
prepareTestEnv(t) defer prepareTestEnv(t)()
session := loginUser(t, "user1") session := loginUser(t, "user1")
req := NewRequest(t, "GET", "/admin/users") req := NewRequest(t, "GET", "/admin/users")
@ -27,7 +27,7 @@ func TestAdminViewUsers(t *testing.T) {
} }
func TestAdminViewUser(t *testing.T) { func TestAdminViewUser(t *testing.T) {
prepareTestEnv(t) defer prepareTestEnv(t)()
session := loginUser(t, "user1") session := loginUser(t, "user1")
req := NewRequest(t, "GET", "/admin/users/1") req := NewRequest(t, "GET", "/admin/users/1")
@ -39,7 +39,7 @@ func TestAdminViewUser(t *testing.T) {
} }
func TestAdminEditUser(t *testing.T) { func TestAdminEditUser(t *testing.T) {
prepareTestEnv(t) defer prepareTestEnv(t)()
testSuccessfullEdit(t, models.User{ID: 2, Name: "newusername", LoginName: "otherlogin", Email: "new@e-mail.gitea"}) testSuccessfullEdit(t, models.User{ID: 2, Name: "newusername", LoginName: "otherlogin", Email: "new@e-mail.gitea"})
} }

Write Preview
Loading…
Cancel
Save