Fix double-indirection bug in logging IDs (#12294)

This PR fixes a bug in log.NewColoredIDValue() which led to a double
indirection and incorrect IDs being printed out.

Signed-off-by: Andrew Thornton <art27@cantab.net>
tokarchuk/v1.17
zeripath 4 years ago committed by GitHub
parent 2753d72773
commit d25f44285a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      modules/log/colors.go

@ -355,7 +355,7 @@ func NewColoredValueBytes(value interface{}, colorBytes *[]byte) *ColoredValue {
// The Value will be colored with FgCyan // The Value will be colored with FgCyan
// If a ColoredValue is provided it is not changed // If a ColoredValue is provided it is not changed
func NewColoredIDValue(value interface{}) *ColoredValue { func NewColoredIDValue(value interface{}) *ColoredValue {
return NewColoredValueBytes(&value, &fgCyanBytes) return NewColoredValueBytes(value, &fgCyanBytes)
} }
// Format will format the provided value and protect against ANSI color spoofing within the value // Format will format the provided value and protect against ANSI color spoofing within the value

Loading…
Cancel
Save