Update milestone counters when issue is deleted (#21459) (#21586)

Backports #21459 

When actions besides "delete" are performed on issues, the milestone
counter is updated. However, since deleting issues goes through a
different code path, the associated milestone's count wasn't being
updated, resulting in inaccurate counts until another issue in the same
milestone had a non-delete action performed on it.

I verified this change fixes the inaccurate counts using a local docker
build.

Co-authored-by: 6543 <6543@obermui.de>
tokarchuk/v1.17
Ashley Nelson 2 years ago committed by GitHub
parent 2ccf940464
commit e504410708
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 5
      services/issue/issue.go

@ -224,6 +224,11 @@ func deleteIssue(issue *issues_model.Issue) error {
return err return err
} }
if err := issues_model.UpdateMilestoneCounters(ctx, issue.MilestoneID); err != nil {
return fmt.Errorf("error updating counters for milestone id %d: %w",
issue.MilestoneID, err)
}
if err := models.DeleteIssueActions(ctx, issue.RepoID, issue.ID); err != nil { if err := models.DeleteIssueActions(ctx, issue.RepoID, issue.ID); err != nil {
return err return err
} }

Loading…
Cancel
Save