Use url.Parse to parse hostname (#12335)

tokarchuk/v1.17
techknowlogick 4 years ago committed by GitHub
parent 7ecb25b41b
commit e6c9f19b8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 7
      modules/setting/setting.go

@ -626,11 +626,8 @@ func NewContext() {
StaticURLPrefix = strings.TrimSuffix(sec.Key("STATIC_URL_PREFIX").MustString(AppSubURL), "/") StaticURLPrefix = strings.TrimSuffix(sec.Key("STATIC_URL_PREFIX").MustString(AppSubURL), "/")
AppSubURLDepth = strings.Count(AppSubURL, "/") AppSubURLDepth = strings.Count(AppSubURL, "/")
// Check if Domain differs from AppURL domain than update it to AppURL's domain // Check if Domain differs from AppURL domain than update it to AppURL's domain
urlHostname, _, err := net.SplitHostPort(appURL.Host) urlHostname := appURL.Hostname()
if err != nil { if urlHostname != Domain && net.ParseIP(urlHostname) == nil && urlHostname != "" {
log.Fatal("Invalid host in ROOT_URL '%s': %s", appURL.Host, err)
}
if urlHostname != Domain && net.ParseIP(urlHostname) == nil {
Domain = urlHostname Domain = urlHostname
} }

Loading…
Cancel
Save