vtest: Replace asserts with if cases

Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Signed-off-by: Jakob Bornecrantz <jakob@collabora.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
macos/master
Jakob Bornecrantz 6 years ago committed by Dave Airlie
parent 6373d5a35f
commit 9b3bab8331
  1. 15
      vtest/vtest_renderer.c

@ -360,6 +360,10 @@ int vtest_create_resource2(void)
args.nr_samples = res_create_buf[VCMD_RES_CREATE2_NR_SAMPLES]; args.nr_samples = res_create_buf[VCMD_RES_CREATE2_NR_SAMPLES];
args.flags = 0; args.flags = 0;
// Check that the handle doesn't already exist.
if (util_hash_table_get(renderer.iovec_hash, intptr_to_pointer(args.handle)))
return -EEXIST;
ret = virgl_renderer_resource_create(&args, NULL, 0); ret = virgl_renderer_resource_create(&args, NULL, 0);
if (ret) if (ret)
return ret; return ret;
@ -376,7 +380,6 @@ int vtest_create_resource2(void)
return -ENOMEM; return -ENOMEM;
virgl_renderer_resource_attach_iov(args.handle, iovec, 1); virgl_renderer_resource_attach_iov(args.handle, iovec, 1);
assert(!util_hash_table_get(renderer.iovec_hash, intptr_to_pointer(args.handle)));
util_hash_table_set(renderer.iovec_hash, intptr_to_pointer(args.handle), iovec); util_hash_table_set(renderer.iovec_hash, intptr_to_pointer(args.handle), iovec);
return ret; return ret;
@ -554,6 +557,10 @@ int vtest_transfer_get2(void)
DECODE_TRANSFER2; DECODE_TRANSFER2;
iovec = util_hash_table_get(renderer.iovec_hash, intptr_to_pointer(handle));
if (!iovec)
return -ESRCH;
ret = virgl_renderer_transfer_read_iov(handle, ret = virgl_renderer_transfer_read_iov(handle,
ctx_id, ctx_id,
level, level,
@ -565,8 +572,6 @@ int vtest_transfer_get2(void)
if (ret) if (ret)
fprintf(stderr," transfer read failed %d\n", ret); fprintf(stderr," transfer read failed %d\n", ret);
iovec = util_hash_table_get(renderer.iovec_hash, intptr_to_pointer(handle));
assert(iovec);
ret = vtest_block_write(renderer.out_fd, ret = vtest_block_write(renderer.out_fd,
iovec->iov_base + offset, iovec->iov_base + offset,
data_size); data_size);
@ -591,7 +596,9 @@ int vtest_transfer_put2(void)
DECODE_TRANSFER2; DECODE_TRANSFER2;
iovec = util_hash_table_get(renderer.iovec_hash, intptr_to_pointer(handle)); iovec = util_hash_table_get(renderer.iovec_hash, intptr_to_pointer(handle));
assert(iovec); if (!iovec)
return -ESRCH;
ret = vtest_block_read(renderer.in_fd, iovec->iov_base + offset, data_size); ret = vtest_block_read(renderer.in_fd, iovec->iov_base + offset, data_size);
if (ret < 0) if (ret < 0)
return ret; return ret;

Loading…
Cancel
Save